Added Docs, Ran Credo#29
Merged
Merged
Conversation
jeregrine
force-pushed
the
js/code-review
branch
from
e34c6b7 to
9d70448
Compare
| def send_event(%Event{} = event) do | ||
| {endpoint, public_key, secret_key} = Application.fetch_env!(:sentry, :dsn) | ||
| |> parse_dsn! | ||
| {endpoint, public_key, secret_key} = parse_dsn!(Application.fetch_env!(:sentry, :dsn)) |
Contributor
There was a problem hiding this comment.
I guess I don't understand credo's issue with this. piping the result of a function into another function is readable enough?
Especially compared to nesting function calls
Contributor
Author
There was a problem hiding this comment.
Eh I don't mind either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is