Skip to content

Check that DSN is binary before trying URI.parse #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Check that DSN is binary before trying URI.parse #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/sentry/client.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ defmodule Sentry.Client do
def get_dsn do
dsn = Config.dsn()

with %URI{userinfo: userinfo, host: host, port: port, path: path, scheme: protocol}
with dsn when is_binary(dsn) <- dsn,
%URI{userinfo: userinfo, host: host, port: port, path: path, scheme: protocol}
when is_binary(path) and is_binary(userinfo) <- URI.parse(dsn),
[public_key, secret_key] <- keys_from_userinfo(userinfo),
[_, binary_project_id] <- String.split(path, "/"),
Expand Down
16 changes: 16 additions & 0 deletions test/client_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,22 @@ defmodule Sentry.ClientTest do
end)
end

test "errors on nil dsn" do
modify_env(:sentry, dsn: nil)

capture_log(fn ->
assert :error = Sentry.Client.get_dsn()
end)
end

test "errors on atom dsn" do
modify_env(:sentry, dsn: :error)

capture_log(fn ->
assert :error = Sentry.Client.get_dsn()
end)
end

test "logs api errors" do
bypass = Bypass.open()

Expand Down