Default scrubbers #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
default-scrubbers
branch
from
2ec3c10 to
07a987e
Compare
jeregrine
reviewed
Nov 15, 2016
CHANGELOG.md
Outdated
| ## 2.0.0 (2016-11-15) | ||
|
|
||
| * Enhancements | ||
| * Provide default scrubber for request body and headers (`Sentry.Plug.default_scrubber` and `Sentry.Plug.default_header_scrubber`) |
There was a problem hiding this comment.
we should name this default_body_scrubber
There was a problem hiding this comment.
You will also need to update the .rst files in /doc
jeregrine
reviewed
Nov 15, 2016
lib/sentry/plug.ex
Outdated
| To configure scrubbing body and header data, we can set both configuration keys: | ||
| use Sentry.Plug, header_scrubber: &scrub_headers/1, scrubber: &scrub_params/1 |
There was a problem hiding this comment.
also call this body_scrubber
| defp scrub_headers(data) do | ||
| Map.drop(data, ~w(authorization authentication)) | ||
| def default_header_scrubber(conn) do | ||
| Enum.into(conn.req_headers, %{}) |
mitchellhenke
force-pushed
the
default-scrubbers
branch
from
6fb3e44 to
4e2b2ef
Compare
mitchellhenke
force-pushed
the
default-scrubbers
branch
from
04a0c8d to
bf3358e
Compare
mitchellhenke
force-pushed
the
default-scrubbers
branch
from
bf3358e to
6eb99c1
Compare
jeregrine
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeregrine
This includes breaking changes for how request data is sent back, so the next release (2.0.0) will be a major version change.
closes #86