Skip to content

Fix: testing names and windows compatibility#1444

Merged
maciejwalkowiak merged 4 commits into
mainfrom
gh-1393
Apr 28, 2021
Merged

Fix: testing names and windows compatibility#1444
maciejwalkowiak merged 4 commits into
mainfrom
gh-1393

Conversation

@maciejwalkowiak

Copy link
Copy Markdown
Contributor

📜 Description

Fix: testing names and windows compatibility

💡 Motivation and Context

Fixes #1393

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review April 28, 2021 10:18
@codecov-commenter

codecov-commenter commented Apr 28, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1444 (1ec1f55) into main (a33afef) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1444      +/-   ##
============================================
- Coverage     75.88%   75.87%   -0.02%     
- Complexity     1889     1901      +12     
============================================
  Files           187      189       +2     
  Lines          6453     6499      +46     
  Branches        633      640       +7     
============================================
+ Hits           4897     4931      +34     
- Misses         1261     1272      +11     
- Partials        295      296       +1     
Impacted Files Coverage Δ Complexity Δ
...n/java/io/sentry/spring/boot/SentryProperties.java 76.66% <0.00%> (-4.82%) 9.00% <0.00%> (+1.00%) ⬇️
...entry/spring/SentryUserProviderEventProcessor.java 96.55% <0.00%> (ø) 12.00% <0.00%> (ø%)
...entry/spring/SpringSecuritySentryUserProvider.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...c/main/java/io/sentry/spring/SentryUserFilter.java 92.85% <0.00%> (ø) 10.00% <0.00%> (?%)
...io/sentry/spring/boot/SentryAutoConfiguration.java 98.18% <0.00%> (+0.18%) 1.00% <0.00%> (ø%)
.../io/sentry/spring/tracing/SentryTracingFilter.java 81.57% <0.00%> (+5.26%) 7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33afef...1ec1f55. Read the comment docs.

Comment thread CHANGELOG.md Outdated
maciejwalkowiak and others added 2 commits April 28, 2021 14:59
…ot/SentryAutoConfigurationTest.kt

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor
Fails
🚫 Please consider adding a changelog entry for the next release.
`Instructions and example for changelog`$

Please add an entry to CHANGELOG.md` to the "Unreleased" section under the following heading:

To the changelog entry, please add a link to this PR (consider a more descriptive message):`

- testing names and windows compatibility(#1444)

If none of the above apply, you can opt out by adding _#skip-changelog_ to the PR description.

Generated by 🚫 dangerJS against 1ec1f55

@marandaneto

Copy link
Copy Markdown
Contributor

@maciejwalkowiak please use _#skip-changelog_ in the PR description, whenever there's no changelog, otherwise we get broken CI

@maciejwalkowiak maciejwalkowiak merged commit 0ac7fde into main Apr 28, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1393 branch April 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix testing names and windows compat.

3 participants