Skip to content

Fix: testing names and windows compatibility #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciejwalkowiak merged 4 commits into from
Apr 28, 2021
Merged

Fix: testing names and windows compatibility #1444

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3eae65b
Fix: testing names and windows compatibility
maciejwalkowiak Apr 28, 2021
d748f2d
Changelog.
maciejwalkowiak Apr 28, 2021
3432fac
Update sentry-spring-boot-starter/src/test/kotlin/io/sentry/spring/bo…
maciejwalkowiak Apr 28, 2021
1ec1f55
Update CHANGELOG.md
maciejwalkowiak Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...-spring-boot-starter/src/test/kotlin/io/sentry/spring/boot/SentryAutoConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ class SentryAutoConfigurationTest {
}

@Test
fun `OptionsConfiguration is created if custom one with name "sentryOptionsConfiguration" is not provided`() {
fun `OptionsConfiguration is created if custom one with name sentryOptionsConfiguration is not provided`() {
contextRunner.withPropertyValues("sentry.dsn=http://key@localhost/proj")
.run {
assertThat(it).hasSingleBean(Sentry.OptionsConfiguration::class.java)
}
}

@Test
fun `OptionsConfiguration with name "sentryOptionsConfiguration" is created if another one with different name is provided`() {
fun `OptionsConfiguration with name sentryOptionsConfiguration is created if another one with different name is provided`() {
contextRunner.withPropertyValues("sentry.dsn=http://key@localhost/proj")
.withUserConfiguration(CustomOptionsConfigurationConfiguration::class.java)
.run {
Expand All @@ -96,7 +96,7 @@ class SentryAutoConfigurationTest {
}

@Test
fun `"sentryOptionsConfiguration" bean is configured before custom OptionsConfiguration`() {
fun `sentryOptionsConfiguration bean is configured before custom OptionsConfiguration`() {
contextRunner.withPropertyValues("sentry.dsn=http://key@localhost/proj")
.withUserConfiguration(CustomOptionsConfigurationConfiguration::class.java)
.run {
Expand All @@ -106,7 +106,7 @@ class SentryAutoConfigurationTest {
}

@Test
fun `OptionsConfiguration is not created if custom one with name "sentryOptionsConfiguration" is provided`() {
fun `OptionsConfiguration is not created if custom one with name sentryOptionsConfiguration is provided`() {
contextRunner.withPropertyValues("sentry.dsn=http://key@localhost/proj")
.withUserConfiguration(OverridingOptionsConfigurationConfiguration::class.java)
.run {
Expand Down Expand Up @@ -163,7 +163,7 @@ class SentryAutoConfigurationTest {
assertThat(options.isAttachStacktrace).isEqualTo(true)
assertThat(options.serverName).isEqualTo("host-001")
assertThat(options.exceptionResolverOrder).isEqualTo(100)
assertThat(options.proxy).isNotNull()
assertThat(options.proxy).isNotNull
assertThat(options.proxy!!.host).isEqualTo("example.proxy.com")
assertThat(options.proxy!!.port).isEqualTo("8090")
assertThat(options.proxy!!.user).isEqualTo("proxy-user")
Expand Down