test: Verify Java 8 API check in logback#5746
Closed
adinauer wants to merge 2 commits into
Closed
Conversation
📲 Install BuildsAndroid
|
9 tasks
Contributor
Performance metrics 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Intentionally introduce the Java 9-only
Objects.requireNonNullElse(Object, Object)API in thesentry-logbackmodule.This PR is a validation PR for #5745 and is expected to fail the new Java 8 API compatibility workflow.
💡 Motivation and Context
This verifies that the Codehaus Java 8 Animal Sniffer signature check catches Java 8 runtime incompatibilities outside the core
:sentrymodule too.💚 How did you test it?
Expected failure:
Formatting/API generation still passes:
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Close this PR after confirming the workflow fails as expected.
#skip-changelog