Skip to content

Conversation

@chargome
Copy link
Member

No description provided.

JPeer264 and others added 12 commits November 4, 2025 15:54
…18057)

In #18029 the expectation is that the `withMonitor` is creating a new
trace. Currently it is not reflected in the docs what is expected when
`withMonitor` is executed. This test proofs that this is the case.
[Gitflow] Merge master into develop
…ed (#18019)

Pass `ignoreCSSAttributes` with `background-imgae` to ignore background
images when `blockAllMedia` is enabled. `ignoreCSSAttributes` was
expanded in [this PR](getsentry/rrweb#252) so
that it also works for inline styles.
…18044)

The exception keys can be left without truncation to leave this decision
on Relay.

part of #17389
Enabling eslint rules for RegEx in `dev-packages`.

This is a part of this (now closed) PR:
#18053

The first commit contains all changes that were automatically made with
`--fix`, the second commit contains the manual changes.
- Fixing some of the types according to the specs.
…tric` (#18088)

- Adds top level options for `enableMetrics` and `beforeSendMetric`.
- Kept the experimental flags for now to stay backwards compatible, but
added a deprecation note and todo comments for removing them in v11.
- Updated all the tests to use the top-level flag.
- Had to refactor the `_INTERNAL_captureMetric` function since it broke
the complexity threshold of our linter

> [!WARNING]  
> `enableMetrics` now defaults to `true`, so theoretically this PR is
behaviourally breaking.
We need to stop accessing params within our wrapper templates as this
can break statically rendered pages and cause cache busts in dynamic
pages.

Opened #18115 to
investigate other ways of handling the functionality we're removing
here.

closes #18097
closes #17431

Note: There's some unused code in the utils that I did not delete as we
might be able to reuse this in
#18115
I can't reproduce the flakiness locally, I logged a few things on CI
runs and it seems while the fetch spans does get created, it doesn't get
created on the middletrasnaction.

This is similar to what the note is saying in dev-mode, for it to be
less flakey I'm asserting if it either has the span on the right
transaction or if it got created in a separate transaction. Ideally we
want it to be created within the middleware transaction but it seems
like there is a timing issue preventing it from being picked up there.

At any case this seems to reduce or eliminate the chances of failed
runs, previously it would fail consistently but with this it didn't fail
in 5 runs so far.
… layer extension via env variables (#18101)

Our recommended approach for the aws sdk is to use our Lambda layer.
When the Lambda layer is used, it would previously automatically set up
the layer extension. This can be disabled by setting `useLayerExtension:
false` during init, but when using the layer with our auto-wrapping as
per recommendation, it wasn't possible to opt out of using the
extension.

This PR adds `SENTRY_LAYER_EXTENSION` that can be used to opt out of the
extension.

---------

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
closes #18125

We want to delete `*.map.css` files when `deleteSourcemapsAfterUpload`
is enabled.
@chargome chargome self-assigned this Nov 10, 2025
@chargome chargome requested a review from a team as a code owner November 10, 2025 10:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.59 kB added added
@sentry/browser - with treeshaking flags 23.08 kB added added
@sentry/browser (incl. Tracing) 41.22 kB added added
@sentry/browser (incl. Tracing, Profiling) 45.5 kB added added
@sentry/browser (incl. Tracing, Replay) 79.7 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.37 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 84.39 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 96.57 kB added added
@sentry/browser (incl. Feedback) 41.27 kB added added
@sentry/browser (incl. sendFeedback) 29.26 kB added added
@sentry/browser (incl. FeedbackAsync) 34.19 kB added added
@sentry/react 26.29 kB added added
@sentry/react (incl. Tracing) 43.21 kB added added
@sentry/vue 29.07 kB added added
@sentry/vue (incl. Tracing) 42.99 kB added added
@sentry/svelte 24.61 kB added added
CDN Bundle 26.89 kB added added
CDN Bundle (incl. Tracing) 41.77 kB added added
CDN Bundle (incl. Tracing, Replay) 78.3 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 83.77 kB added added
CDN Bundle - uncompressed 78.84 kB added added
CDN Bundle (incl. Tracing) - uncompressed 123.97 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 240 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 252.76 kB added added
@sentry/nextjs (client) 45.31 kB added added
@sentry/sveltekit (client) 41.61 kB added added
@sentry/node-core 50.76 kB added added
@sentry/node 157.82 kB added added
@sentry/node - without tracing 92.64 kB added added
@sentry/aws-serverless 106.4 kB added added

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,267 - - added
GET With Sentry 1,301 14% - added
GET With Sentry (error only) 6,062 65% - added
POST Baseline 1,154 - - added
POST With Sentry 488 42% - added
POST With Sentry (error only) 1,018 88% - added
MYSQL Baseline 3,286 - - added
MYSQL With Sentry 354 11% - added
MYSQL With Sentry (error only) 2,676 81% - added

@chargome chargome force-pushed the prepare-release/10.24.0 branch from 99eb4c8 to 59028df Compare November 10, 2025 11:53
@chargome chargome force-pushed the prepare-release/10.24.0 branch from 59028df to 0054094 Compare November 10, 2025 11:56
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for taking care of the release!

@chargome chargome merged commit e861b4f into master Nov 10, 2025
192 checks passed
@chargome chargome deleted the prepare-release/10.24.0 branch November 10, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants