test(nextjs-16-streaming): Skip server-component tests in dev mode#21053
Merged
mydea merged 1 commit intoMay 20, 2026
Merged
Conversation
The two server-component tests at line 20 and 43 hit the same Turbopack nested-route bug that already makes the line-5 test skip in dev mode: `GET /nested-layout` and `GET /nested-layout/123` return 404 from the dev server in a route-group context, the page never loads, no spans are emitted, and Playwright hits its 30s timeout. Adds the same `test.skip(isDevMode, ...)` guard to both tests, mirroring line 5. Fixes #21023 Fixes #21000 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
chargome
approved these changes
May 20, 2026
mydea
added a commit
that referenced
this pull request
May 20, 2026
Dogfooding produced PRs (#21055, #21053) with literal backslash-backticks in their bodies because the body got passed through `gh pr create --body "$(cat <<'EOF' ... EOF)"`, where I needlessly escaped backticks out of shell-quoting paranoia, breaking every code block. Tell the agent to write the body to a file with the `Write` tool, then pass `--body-file` to `gh pr create`. The body never touches Bash quoting, so backticks, dollar signs, and parens render exactly as written. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mydea
added a commit
that referenced
this pull request
May 20, 2026
Dogfooding produced PRs (#21055, #21053) with literal backslash-backticks in their bodies because the body got passed through `gh pr create --body "$(cat <<'EOF' ... EOF)"`, where I needlessly escaped backticks out of shell-quoting paranoia, breaking every code block. Tell the agent to write the body to a file with the `Write` tool, then pass `--body-file` to `gh pr create`. The body never touches Bash quoting, so backticks, dollar signs, and parens render exactly as written. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test.skip(isDevMode, ...)to the two server-component tests at lines 20 and 43 ofnextjs-16-streaming/tests/server-components.test.ts, mirroring the existing guard already on the line-5 sibling test.Root cause
The dev-mode run of job 76892959990 shows the dev server returning 404 every time the tests navigate into the
(nested-layout)route group:The page never loads, no
GET /nested-layoutsegment span is emitted,waitForStreamedSpansnever resolves, and Playwright times out after 30 s on all four attempts.This is the same Turbopack-in-dev bug already called out in the existing line-5 skip:
The fix reuses that exact line on both affected tests.
test:prodcontinues to run them and is unaffected.Fixes #21023
Fixes #21000
🤖 Generated with Claude Code