test(node-integration): Raise kafkajs test timeout to 90s#21055
Merged
Conversation
The test wraps a full docker-compose-up + kafka broker readiness + producer/consumer scenario under a single 60s Vitest timeout. The docker-compose healthcheck alone can take up to ~75s before the broker reports ready (15s start_period + retries), leaving very little headroom for the scenario itself on a busy CI runner — and producing a flaky "Test timed out in 60000ms" failure. Bump the per-test timeout from 60_000 to 90_000, matching the existing postgres / postgresjs heavier-weight docker-compose tests. Fixes #20840 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mydea
added a commit
that referenced
this pull request
May 20, 2026
Dogfooding produced PRs (#21055, #21053) with literal backslash-backticks in their bodies because the body got passed through `gh pr create --body "$(cat <<'EOF' ... EOF)"`, where I needlessly escaped backticks out of shell-quoting paranoia, breaking every code block. Tell the agent to write the body to a file with the `Write` tool, then pass `--body-file` to `gh pr create`. The body never touches Bash quoting, so backticks, dollar signs, and parens render exactly as written. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JPeer264
approved these changes
May 20, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
Not sure if raising the timeout is the best here. 1 minute is already quite some time, but yeah, it already handles quite some stuff. Let's see if it gets better
mydea
added a commit
that referenced
this pull request
May 20, 2026
Dogfooding produced PRs (#21055, #21053) with literal backslash-backticks in their bodies because the body got passed through `gh pr create --body "$(cat <<'EOF' ... EOF)"`, where I needlessly escaped backticks out of shell-quoting paranoia, breaking every code block. Tell the agent to write the body to a file with the `Write` tool, then pass `--body-file` to `gh pr create`. The body never touches Bash quoting, so backticks, dollar signs, and parens render exactly as written. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suites/tracing/kafkajs/test.tsfrom60_000to90_000, matching the existingpostgres/postgresjsheavier-weight docker-compose tests.Root cause
Failing run:
The Vitest
{ timeout: 60_000 }covers everything:docker-compose up+ kafka broker healthcheck + scenario (connect admin, connect producer, create topic, connect consumer, subscribe, 4 s wait, produce, consume, both spans flushed). The compose healthcheck alone can take up to ~75 s on a busy runner (15 sstart_period+ 30 retries × 2 s interval), leaving the actual scenario little to no headroom.Raising to
90_000adds 50% of margin while staying within the precedent set by sibling heavy-broker tests (postgres,postgresjsline 419/508 both use{ timeout: 90_000 }).Fixes #20840
🤖 Generated with Claude Code