feat(angular): Set url attributes on pageload and navigation spans#21985
Merged
Lms24 merged 2 commits intoJul 8, 2026
Conversation
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
41cc9bd to
3831498
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
9afa5d7 to
26d8b46
Compare
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
26d8b46 to
d7ce684
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
3831498 to
2ad4840
Compare
Lms24
requested review from
chargome,
mydea and
s1gr1d
and removed request for
a team
chargome
approved these changes
Jul 6, 2026
| data: { | ||
| 'sentry.origin': 'auto.pageload.angular', | ||
| 'sentry.source': 'route', | ||
| 'url.template': '/home/', |
Member
There was a problem hiding this comment.
q: We always want trailing slashes for this?
Member
Author
There was a problem hiding this comment.
I think we generally don't want trailing slashes, but since url.template should ideally be 100% the same as the current span description (to avoid any filtering/grouping changes in the product) I'll take it for now. We're consistent because:
- if we get a parameterized url, both
url.templateandspan.descriptionhave a trailing slash - if we don't get a paramterized url,
url.templateisn't set,url.pathhas no trailing slash and neither doesspan.description.
Not great but I think it's fine. We could adjust our instrumentation in a major to no longer set trailing slashes for paramterized routes but I'd say it's logaf-l
s1gr1d
approved these changes
Jul 7, 2026
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
2ad4840 to
8832da5
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
d7ce684 to
76f14ee
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 76f14ee. Configure here.
Lms24
changed the title
url attributes on pageload and navigation spans
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
76f14ee to
212546b
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
8832da5 to
67c4c14
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
67c4c14 to
64bc88c
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
212546b to
c99fd2d
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
64bc88c to
6a03681
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
2 times, most recently
from
ed91749 to
b96995b
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
2 times, most recently
from
00994ef to
c7c516d
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
b96995b to
5054905
Compare
Add url.full, url.path, and url.template to Angular tracing spans, resolve relative router URLs against the current origin, and extend e2e performance tests to assert the new attributes. Co-Authored-By: Cursor <cursoragent@cursor.com>
Lms24
force-pushed
the
feat/pageload-url-attrs-base
branch
from
c7c516d to
975a966
Compare
Lms24
force-pushed
the
feat/pageload-url-attrs-angular
branch
from
5054905 to
9717e85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts the Angular routing instrumentation to set
url.templateand updateurl.fullandurl.pathwhen resolving routes. We not only have to settemplate(which we can only do in the framework/router-specific instrumentation). We also have to ensure we setfullandpathagain because in the default integration (#21952), we set it to early based on the window location path. So therefore, we update it again in the router instrumentation and re-set the raw URL (but the resolved one).ref #21921