test(node): Fix flaky negative sampling (static) envelope ordering#22038
Merged
Conversation
mydea
approved these changes
Jul 8, 2026
andreiborza
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
negative sampling (static)integration test (suites/tracing/sampling-static/test.ts) intermittently failed on CI with an envelope-ordering assertion error.Root cause
The test used ordered envelope matching, expecting the
GET /oktransactionto arrive before theclient_reportthat records the negatively-sampled/healthsample_rateoutcome. These two envelopes originate from independent flush mechanisms:GET /oktransaction is transmitted as soon as its root span ends./healthoutcome only leaves the SDK via the client report flushed onclientReportFlushInterval(1000ms).Because the flush timings are independent, their relative arrival order is racy. When the client-report interval fires after the
/healthoutcome is recorded but before the/oktransaction is transmitted, theclient_reportarrives first and the ordered matcher throwsExpected envelope item type 'transaction' but got 'client_report'.Fix
Add
.unordered()so envelope arrival order no longer matters. Both assertions (thetransactionand theclient_report) are still required to arrive and are checked exactly as before — only the strict sequencing is relaxed. This mirrors the pattern already used intracing/postgresjs,tracing/apollo-graphql, andexpress/handle-error.Fixes #21990