Skip to content

test(server-utils): Remove mongoose unit test that replicated SDK async-context logic#22101

Merged
andreiborza merged 2 commits into
developfrom
ab/remove-mongoose-unit-test
Jul 8, 2026
Merged

test(server-utils): Remove mongoose unit test that replicated SDK async-context logic#22101
andreiborza merged 2 commits into
developfrom
ab/remove-mongoose-unit-test

Conversation

@andreiborza

@andreiborza andreiborza commented Jul 8, 2026

Copy link
Copy Markdown
Member

Removes the mongoose unit test that stubbed the SDK's async context strategy to drive spans, which replicated SDK internals in the test layer. Per the review thread in #21885, we rely on the integration tests instead.

The path is covered by the mongoose-tracing-channel node integration suite. To avoid losing the useful unit-only assertions, this PR also adds error-status, empty-filter, and cursor-batchSize coverage to that suite.

Ref: #21885 (comment)

…nc-context logic

The suite stubbed the SDK's async context strategy via `setAsyncContextStrategy` to
drive spans, duplicating SDK internals in the test layer. The mongoose-tracing-channel
node integration suite already covers the diagnostics-channel subscriber path end to end.

Co-Authored-By: Opus 4.8 <noreply@anthropic.com>
@andreiborza andreiborza requested a review from a team as a code owner July 8, 2026 15:26
@andreiborza andreiborza requested review from JPeer264 and mydea and removed request for a team July 8, 2026 15:26
…he mongoose-tracing-channel integration suite
@andreiborza andreiborza merged commit 44a2d08 into develop Jul 8, 2026
412 of 418 checks passed
@andreiborza andreiborza deleted the ab/remove-mongoose-unit-test branch July 8, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants