test(server-utils): Remove graphql unit tests that replicated SDK async-context logic#22103
Merged
Conversation
…nc-context logic The suites stubbed the SDK's async context strategy via `setAsyncContextStrategy` and a fake `DocumentNode` to drive spans, duplicating SDK internals in the test layer. The graphql-tracing-channel node integration suite already covers the graphql v17 native diagnostics-channel subscriber path end to end against the real library. Co-Authored-By: Opus 4.8 <noreply@anthropic.com>
andreiborza
requested review from
JPeer264 and
mydea
and removed request for
a team
…to the graphql-tracing-channel integration suite
logaretm
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the three graphql subscriber unit tests and their shared helper, which stubbed the SDK's async context strategy and a fake document to drive spans, replicating SDK internals in the test layer. Per the review thread in #21885, we rely on the integration tests instead.
The path is covered by the
graphql-tracing-channelnode integration suite. To avoid losing the useful unit-only assertions, this PR also adds validation-error status andignoreTrivialResolveSpanscoverage to that suite. The subscription-channel case is left as a possible follow-up.Ref: #21885 (comment)