test(node-core): Fix flaky withMonitor span order assertion#22129
Merged
Conversation
The withMonitor integration test asserted span order via toMatchObject, but the span exporter does not guarantee child span order. Assert span presence with toContainEqual instead. Fixes #22121 Co-Authored-By: Cursor <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
andreiborza
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky
withMonitorunit test reported in #22121The test asserted child span order via
toMatchObject, but the span exporter does not guarantee ordering by timestamp. The failure in #22121 showed all three expected spans were present with matching trace IDs but only their order differed.Replace the order-sensitive assertion with
toContainEqualchecks, matching the pattern used elsewhere in the same test file.Fixes #22121