fix(vue): Refresh pageload URL attrs on TanStack onResolved#22140
Merged
Conversation
Lms24
force-pushed
the
fix/vue-tanstack-pageload-onresolved
branch
from
e0de32c to
dc4941c
Compare
Lms24
requested review from
chargome,
mydea and
s1gr1d
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Pageload onResolved only updated url.path, url.full, and param attributes when the resolved routeId differed from the initial match. Redirects to the same route template with different params left stale URL fields on the span. Co-Authored-By: Cursor <cursoragent@cursor.com>
Lms24
force-pushed
the
fix/vue-tanstack-pageload-onresolved
branch
from
dc4941c to
82a356b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pageload
onResolvedonly refreshed URL attributes when the resolvedrouteIdchanged. Redirects landing on the same route template with different pathname or params left staleurl.path,url.full, and param attributes on the span.This PR always applies the resolved route match on pageload
onResolved, matching navigation behavior.