feat(deno): add langchain integration - #22471
Merged
isaacs merged 1 commit intoJul 24, 2026
Merged
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 20:43
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 21, 2026 20:55
816c7f6 to
0e76715
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 21, 2026 21:31
0e76715 to
760d0a9
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 21, 2026 21:42
760d0a9 to
5cf5d89
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 22, 2026 00:51
5cf5d89 to
9c44384
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 22, 2026 14:42
9c44384 to
92ba4f1
Compare
isaacs
requested review from
chargome,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
July 22, 2026 14:42
nicohrubec
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 22, 2026 22:02
92ba4f1 to
59377c8
Compare
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 23, 2026 14:29
59377c8 to
af052fe
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 23, 2026 18:10
af052fe to
1c2c8a1
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+57
to
+62
| Deno.test('langchain instrumentation: included in default integrations (Deno 2.8.0+)', () => { | ||
| resetGlobals(); | ||
| const client = init({ dsn: 'https://username@domain/123' }) as DenoClient; | ||
| const names = client.getOptions().integrations.map(i => i.name); | ||
| assert(names.includes('LangChain'), `LangChain should be in defaults, got ${names.join(', ')}`); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: A module-level subscribed flag causes test interference, as it is not reset between test runs, leading to subsequent test failures.
Severity: MEDIUM
Suggested Fix
Reset the state between tests. This can be achieved by adding a beforeEach or afterEach hook in the test suite to reset the subscribed flag. Alternatively, export a dedicated reset function from the langchain.ts module to be called between tests.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-langchain/test.ts#L57-L62
Potential issue: A module-level `subscribed` flag in the LangChain integration causes
test interference. The first test to run calls `init()`, which sets the `subscribed`
flag to `true`. Because Deno tests in the same file run in the same process, they share
module state. When a subsequent test calls `init()`, its `setupOnce()` function sees
that `subscribed` is already `true` and returns early. This prevents crucial tracing
channel listeners from being attached, causing the test to fail its assertion when it
checks for the existence of a span.
Did we get this right? 👍 / 👎 to inform future reviews.
Comment on lines
+57
to
+62
| Deno.test('langchain instrumentation: included in default integrations (Deno 2.8.0+)', () => { | ||
| resetGlobals(); | ||
| const client = init({ dsn: 'https://username@domain/123' }) as DenoClient; | ||
| const names = client.getOptions().integrations.map(i => i.name); | ||
| assert(names.includes('LangChain'), `LangChain should be in defaults, got ${names.join(', ')}`); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: A module-level subscribed flag causes test interference, as it is not reset between test runs, leading to subsequent test failures.
Severity: MEDIUM
Suggested Fix
Reset the state between tests. This can be achieved by adding a beforeEach or afterEach hook in the test suite to reset the subscribed flag. Alternatively, export a dedicated reset function from the langchain.ts module to be called between tests.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-langchain/test.ts#L57-L62
Potential issue: A module-level `subscribed` flag in the LangChain integration causes
test interference. The first test to run calls `init()`, which sets the `subscribed`
flag to `true`. Because Deno tests in the same file run in the same process, they share
module state. When a subsequent test calls `init()`, its `setupOnce()` function sees
that `subscribed` is already `true` and returns early. This prevents crucial tracing
channel listeners from being attached, causing the test to fail its assertion when it
checks for the existence of a span.
Did we get this right? 👍 / 👎 to inform future reviews.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
2 times, most recently
from
July 23, 2026 21:19
71fd09f to
bc7c295
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
2 times, most recently
from
July 23, 2026 22:47
12112f2 to
43a3245
Compare
Comment on lines
+64
to
+74
| Deno.test('langchain instrumentation: orchestrion @langchain/openai:embedQuery channel produces a nested embeddings span', async () => { | ||
| resetGlobals(); | ||
| const sink = transactionSink(); | ||
| init({ | ||
| dsn: 'https://username@domain/123', | ||
| tracesSampleRate: 1, | ||
| beforeSendTransaction: sink.beforeSendTransaction, | ||
| }); | ||
|
|
||
| const channel = tracingChannel('orchestrion:@langchain/openai:embedQuery'); | ||
|
|
Contributor
There was a problem hiding this comment.
Bug: The module-level subscribed flag prevents re-initialization on subsequent init() calls within the same module, causing instrumentation to fail silently after the first call.
Severity: MEDIUM
Suggested Fix
The initialization logic should be made idempotent or the state should be resettable. The subscribed flag should be reset or handled in a way that allows init() to be called multiple times, ensuring that channel subscriptions are correctly re-established each time without breaking existing ones.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-langchain/test.ts#L64-L74
Potential issue: A module-level `subscribed` flag prevents the LangChain integration
from being re-initialized if `init()` is called multiple times within the same module
context. The first call to `init()` sets `subscribed` to `true`. Subsequent calls will
cause the `setupOnce()` function to return early, preventing the
`waitForTracingChannelBinding()` callback from being invoked. This results in channel
subscriptions not being set up, and consequently, LangChain instrumentation spans will
not be created for any operations following the second `init()` call. This is not just a
test issue and can affect production applications that might re-initialize the
integration.
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 24, 2026 01:24
43a3245 to
b5df5c7
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 24, 2026 14:31
b5df5c7 to
bdf5a28
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-langchain
branch
from
July 24, 2026 15:13
bdf5a28 to
329e686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.