ref(react-router): Decouple ServerBuild capture from the OTel patch#22492
Merged
Conversation
Move `registerServerBuildGlobal()` out of the OTel instrumentation setup so the Vite-plugin ServerBuild capture is registered independently in the integration's `setupOnce()`. This keeps the capture path working once the OTel instrumentation is removed. No behavior change - both capture paths remain active. Ref #22290 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chargome
marked this pull request as ready for review
July 22, 2026 12:52
chargome
requested review from
andreiborza,
mydea and
nicohrubec
and removed request for
a team
July 22, 2026 12:52
nicohrubec
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
registerServerBuildGlobal()out of the OTel instrumentation setup and registers the Vite-plugin ServerBuild capture independently in the integration'ssetupOnce(). This keeps the capture path working once the OTel instrumentation is removed in a follow-up.No behavior change — both ServerBuild capture paths (OTel proxy and Vite plugin) remain active.
Fixes #22411
Ref #22290