Skip to content

ref(core): Remove otel-based suppressTracing implementation#22574

Draft
mydea wants to merge 3 commits into
developfrom
fn/suppressTracing
Draft

ref(core): Remove otel-based suppressTracing implementation#22574
mydea wants to merge 3 commits into
developfrom
fn/suppressTracing

Conversation

@mydea

@mydea mydea commented Jul 24, 2026

Copy link
Copy Markdown
Member

Now, by default suppress tracing is async context aware, and we only overwrite this for the stack strategy (in browser) to have special handling (which used to be the default). node, cloudflare, deno can all use the default implementation.

@mydea mydea self-assigned this Jul 24, 2026
Comment thread packages/opentelemetry/src/asyncContextStrategy.ts
getTraceContextForScope,
} from './trace';

export { suppressTracing } from './utils/suppressTracing';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public export removed without notice

Medium Severity

suppressTracing was removed from @sentry/opentelemetry's public exports without a deprecation period. This violates the PR review rule on breaking changes for publicly exported APIs. Flagged because it was mentioned in the rules file.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit a7c1182. Configure here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not care about opentelemetry package removals

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28 kB +0.21% +57 B 🔺
@sentry/browser - with treeshaking flags 26.45 kB +0.21% +53 B 🔺
@sentry/browser (incl. Tracing) 46.44 kB +0.08% +34 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 48.23 kB +0.1% +47 B 🔺
@sentry/browser (incl. Tracing, Profiling) 51.24 kB +0.06% +30 B 🔺
@sentry/browser (incl. Tracing, Replay) 85.73 kB +0.05% +42 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.38 kB +0.07% +49 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 90.44 kB +0.05% +39 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 103.1 kB +0.04% +38 B 🔺
@sentry/browser (incl. Feedback) 45.19 kB +0.14% +62 B 🔺
@sentry/browser (incl. sendFeedback) 32.81 kB +0.22% +69 B 🔺
@sentry/browser (incl. FeedbackAsync) 37.85 kB +0.14% +50 B 🔺
@sentry/browser (incl. Metrics) 29.11 kB +0.23% +64 B 🔺
@sentry/browser (incl. Logs) 29.32 kB +0.21% +61 B 🔺
@sentry/browser (incl. Metrics & Logs) 30.03 kB +0.21% +62 B 🔺
@sentry/react 29.82 kB +0.25% +73 B 🔺
@sentry/react (incl. Tracing) 48.75 kB +0.08% +35 B 🔺
@sentry/vue 33.43 kB +0.15% +47 B 🔺
@sentry/vue (incl. Tracing) 48.44 kB +0.1% +48 B 🔺
@sentry/svelte 28.02 kB +0.22% +59 B 🔺
CDN Bundle 30.31 kB +0.09% +27 B 🔺
CDN Bundle (incl. Tracing) 48.28 kB +0.05% +21 B 🔺
CDN Bundle (incl. Logs, Metrics) 31.88 kB +0.11% +33 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 49.61 kB +0.08% +36 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 71.17 kB +0.06% +38 B 🔺
CDN Bundle (incl. Tracing, Replay) 85.85 kB +0.03% +24 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.15 kB +0.02% +11 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 91.63 kB +0.03% +26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.94 kB +0.06% +50 B 🔺
CDN Bundle - uncompressed 90.23 kB +0.1% +86 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 145.3 kB +0.06% +86 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.94 kB +0.1% +86 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 149.28 kB +0.06% +86 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 219.71 kB +0.04% +86 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 264.54 kB +0.04% +86 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 268.51 kB +0.04% +86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 278.24 kB +0.04% +86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 282.2 kB +0.04% +86 B 🔺
@sentry/nextjs (client) 51.28 kB +0.08% +40 B 🔺
@sentry/sveltekit (client) 46.89 kB +0.1% +45 B 🔺
@sentry/core/server 80.04 kB -0.02% -10 B 🔽
@sentry/core/browser 52 kB -0.03% -12 B 🔽
@sentry/node 123.1 kB -0.04% -37 B 🔽
@sentry/node (incl. diagnostics channel injection) 167.13 kB -0.01% -11 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B - -
@sentry/node - without tracing 73.28 kB -0.03% -21 B 🔽
@sentry/aws-serverless 82.81 kB -0.02% -11 B 🔽
@sentry/cloudflare (withSentry) - minified 197.04 kB -0.01% -12 B 🔽
@sentry/cloudflare (withSentry) 484.79 kB +0.02% +54 B 🔺

View base workflow run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2ba61a0. Configure here.

Comment thread packages/opentelemetry/src/utils/suppressTracing.ts
@mydea
mydea force-pushed the fn/suppressTracing branch from 2ba61a0 to e8aa6c4 Compare July 24, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant