Skip to content

test(browser): Unflake streamed XHR span assertions#22640

Merged
Lms24 merged 1 commit into
developfrom
lms/test-browser-unflake-xhr
Jul 24, 2026
Merged

test(browser): Unflake streamed XHR span assertions#22640
Lms24 merged 1 commit into
developfrom
lms/test-browser-unflake-xhr

Conversation

@Lms24

@Lms24 Lms24 commented Jul 24, 2026

Copy link
Copy Markdown
Member

Sort streamed XHR spans before asserting them to avoid completion-order flakes like this one.

Streamed request spans are emitted in completion order, which is not deterministic for concurrent XHRs. Sort them by URL before asserting their expected contents.

Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24 Lms24 self-assigned this Jul 24, 2026
@Lms24
Lms24 marked this pull request as ready for review July 24, 2026 16:23
@Lms24
Lms24 requested a review from a team as a code owner July 24, 2026 16:23
@Lms24
Lms24 requested review from logaretm and msonnb and removed request for a team July 24, 2026 16:23
@Lms24
Lms24 enabled auto-merge (squash) July 24, 2026 16:23
@Lms24
Lms24 merged commit 2ccddd2 into develop Jul 24, 2026
68 checks passed
@Lms24
Lms24 deleted the lms/test-browser-unflake-xhr branch July 24, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants