feat(astro)!: Drop support for Astro 3 - #22683
Merged
Merged
Conversation
Raises the minimum supported Astro version to 4. The `astro` peer dependency drops `>=3.x`, and the dev dependency moves to `^4.16.19`, pinned to the new floor so the package keeps typechecking against the oldest supported Astro rather than the newest. Removes the `supportsAddMiddleware` guard, which only existed because `addMiddleware` landed in astro@3.5.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
Author
|
buglitzer run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit eb30de1. Configure here.
chargome
marked this pull request as ready for review
July 27, 2026 14:32
chargome
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
July 27, 2026 14:32
Member
|
dumb q: why are we dropping Astro 3 support? |
Member
Author
|
@Lms24 Usage is near 0 and we have some special cased code for this in the SDK. |
Lms24
approved these changes
Jul 28, 2026
s1gr1d
approved these changes
Jul 28, 2026
| }, | ||
| "peerDependencies": { | ||
| "astro": ">=3.x || >=4.0.0-beta || >=7.0.0-beta" | ||
| "astro": ">=4.0.0-beta || >=7.0.0-beta" |
Member
There was a problem hiding this comment.
I am just wondering why we don't support the beta versions of 5 and 6. But almost no one is using them, so I guess it's fine to keep them out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the minimum supported Astro version to 4. The
astropeer dependency drops>=3.x, and the dev dependency moves to^4.16.19— pinned to the new floor so the package keeps typechecking against the oldest supported Astro rather than the newest.Removes the
supportsAddMiddlewareguard, which only existed becauseaddMiddlewarelanded in astro@3.5.0. README, JSDoc, and comments documenting the 3.5.0 conditional are updated; the manual-middleware snippet moves under "Disable Automatic Server Instrumentation", where it's still relevant.MIGRATION.mdalready documents the drop.closes #21462