fix(nuxt): Move @nuxt/kit to peer/dev deps to avoid duplicate on Nuxt 4 - #22713
fix(nuxt): Move @nuxt/kit to peer/dev deps to avoid duplicate on Nuxt 4#22713thijsw wants to merge 1 commit into
@nuxt/kit to peer/dev deps to avoid duplicate on Nuxt 4#22713Conversation
|
🚧 Skipped: PR exceeds review size limit. Please split into smaller PRs and re-run. |
42180eb to
25c909d
Compare
|
@thijsw Please base the branch on |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 25c909d. Configure here.
| "access": "public" | ||
| }, | ||
| "peerDependencies": { | ||
| "@nuxt/kit": "^3.13.2 || ^4.0.0", |
There was a problem hiding this comment.
Kit peer range mismatch
Medium Severity
Moving @nuxt/kit to a required peer keeps the old ^3.13.2 floor, but the nuxt peer still allows >=3.7.0 and 5.x. Nuxt ships kit in lockstep, so supported 3.7–3.12 apps and future Nuxt 5 apps will not satisfy this peer and can hit unmet-peer install failures or warnings. As a dependency that floor only constrained what the SDK installed; as a peer it now constrains host compatibility.
Reviewed by Cursor Bugbot for commit 25c909d. Configure here.
| "local-pkg": "^1.1.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@nuxt/kit": "^3.13.2", |
There was a problem hiding this comment.
Missing fix regression test
Low Severity
This is a fix PR but it adds no unit, integration, or E2E coverage that would fail without the change and pass with it—for example asserting a single deduped @nuxt/kit on Nuxt 4. Flagged per the Testing Conventions rule for fix PRs.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 25c909d. Configure here.
…xt 4 `@sentry/nuxt` declared `@nuxt/kit: ^3.13.2` as a regular dependency. On a Nuxt 4 app (`@nuxt/kit@4.x`), the `^3` cap (`>=3.13.2 <4.0.0`) can't dedupe with the app's 4.x, forcing a second copy of `@nuxt/kit` into the tree. Move `@nuxt/kit` to `devDependencies` (for building/testing against 3.x) and add it as a `peerDependency` with a widened range so the host Nuxt app supplies the single, deduplicated version.
25c909d to
335d524
Compare
2 participants
Summary
@sentry/nuxtdeclares@nuxt/kit: ^3.13.2as a regular dependency. On a Nuxt 4 app (@nuxt/kit@4.x), the^3cap (>=3.13.2 <4.0.0) can't dedupe with the app's 4.x, so a second copy of@nuxt/kit(3.x) gets installed next to the app's 4.x:Following @s1gr1d's suggestion in the issue, this moves
@nuxt/kit:dependenciesdevDependencies(^3.13.2) — so the SDK still builds/tests against 3.xpeerDependencies(^3.13.2 || ^4.0.0) — so the host Nuxt app supplies the single, deduplicated version@nuxt/kit4.x is backward compatible with the 3.x APIs the module uses, andnuxtis already a required peer (which itself provides@nuxt/kit), so a required@nuxt/kitpeer is safe.No lockfile change: the
^3.13.2range is unchanged (now via the devDependency), and yarn classic does not lock peerDependencies.Closes #22679