ref(node): Remove vendored generic-pool instrumentation - #22733
Merged
Conversation
This instrumentation is dead code: the generic-pool integration is provided by the channel-based implementation in `@sentry/server-utils` (default since #22501), and the vendored OpenTelemetry instrumentation here is no longer wired up. Ref: #22346 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
marked this pull request as ready for review
July 28, 2026 11:02
andreiborza
requested review from
JPeer264,
chargome,
msonnb and
stephanie-anderson
and removed request for
a team,
msonnb and
stephanie-anderson
July 28, 2026 11:02
chargome
approved these changes
Jul 28, 2026
JPeer264
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the dead vendored OpenTelemetry generic-pool instrumentation from
@sentry/node.Why
The generic-pool integration is now provided by the channel-based implementation in
@sentry/server-utils(the default since #22501). The vendored instrumentation here is no longer wired into the SDK, so it is pure dead code.Ref: #22346