Skip to content

ref(node): Remove vendored express instrumentation #22749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 1 commit into from
Jul 28, 2026
+1 −56
Merged

ref(node): Remove vendored express instrumentation #22749

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 1 addition & 56 deletions packages/node/src/integrations/tracing/express.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,6 @@
// Automatic istrumentation for Express using OTel
import type { InstrumentationConfig } from '@opentelemetry/instrumentation';
import { InstrumentationBase, InstrumentationNodeModuleDefinition } from '@opentelemetry/instrumentation';

import { generateInstrumentOnce } from '../../otel/instrument';
import { ensureIsWrapped } from '../../utils/ensureIsWrapped';
import {
type ExpressIntegrationOptions,
debug,
patchExpressModule,
SDK_VERSION,
setupExpressErrorHandler as coreSetupExpressErrorHandler,
type ExpressHandlerOptions,
} from '@sentry/core';
import { setupExpressErrorHandler as coreSetupExpressErrorHandler, type ExpressHandlerOptions } from '@sentry/core';
export { expressErrorHandler } from '@sentry/core';
import { DEBUG_BUILD } from '../../debug-build';
import { setHttpServerSpanRouteAttribute } from '../../utils/setHttpServerSpanRouteAttribute';

const INTEGRATION_NAME = 'Express' as const;
const SUPPORTED_VERSIONS = ['>=4.0.0 <6'];

export function setupExpressErrorHandler(
//oxlint-disable-next-line no-explicit-any
Expand All @@ -27,41 +10,3 @@ export function setupExpressErrorHandler(
coreSetupExpressErrorHandler(app, options);
ensureIsWrapped(app.use, 'express');
}

export type ExpressInstrumentationConfig = InstrumentationConfig &
Omit<ExpressIntegrationOptions, 'express' | 'onRouteResolved'>;

export const instrumentExpress = generateInstrumentOnce(
INTEGRATION_NAME,
(options?: ExpressInstrumentationConfig) => new ExpressInstrumentation(options),
);

export class ExpressInstrumentation extends InstrumentationBase<ExpressInstrumentationConfig> {
public constructor(config: ExpressInstrumentationConfig = {}) {
super('sentry-express', SDK_VERSION, config);
}
public init(): InstrumentationNodeModuleDefinition {
const module = new InstrumentationNodeModuleDefinition(
'express',
SUPPORTED_VERSIONS,
express => {
try {
patchExpressModule(express, () => ({
...this.getConfig(),
onRouteResolved(route) {
if (route) {
setHttpServerSpanRouteAttribute(route);
}
},
}));
} catch (e) {
DEBUG_BUILD && debug.error('Failed to patch express module:', e);
}
return express;
},
// we do not ever actually unpatch in our SDKs
express => express,
);
return module;
}
}
Loading