fix(effect): Set sentry.origin on logs from SentryEffectLogger - #22762
Conversation
`SentryEffectLogger` forwarded Effect log records to Sentry via bare `logger.<level>(msg)` calls without an attributes argument, so the logs it emitted carried no `sentry.origin`. That made them indistinguishable from manual `Sentry.logger.*` calls, which per spec must omit the attribute, leaving no way to attribute these logs to the Effect integration. Every other logging auto-instrumentation (console, consola, pino, winston) already sets an `auto.log.*` origin. Set `auto.log.effect` here, matching the `*.effect` convention the package's span origins already use. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dd27fc1. Configure here.
| expect.any(String), | ||
| expect.objectContaining({ 'sentry.origin': 'auto.log.effect' }), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Loop over log levels in test
Low Severity
Flagged because it was mentioned in the review rules file: the Testing Conventions rule against loops that cover multiple scenarios in one test. The new origin coverage test iterates log levels in a for loop instead of using it.each / test.each (or separate cases). The per-level cases above already assert LOG_ATTRIBUTES, so this looped case is also largely redundant.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit dd27fc1. Configure here.
There was a problem hiding this comment.
Not sure if effect even supports it.each and my logaf here is really low. if reviewers have more opinions/insights happy to change
2 participants
SentryEffectLoggerforwarded Effect log records vialogger.<level>(msg)calls with no attributes argument, so its logs carried nosentry.origin. This makes them indistinguishable from manualSentry.logger.*calls, which per spec must omit the attribute. It was the only logging auto-instrumentation missing an origin; console, consola, pino and winston all set one.Uses
auto.log.effect, matching the spec'sauto.log.<name>shape for logging-library capture and the*.effectconvention this package's span origins already use.This needs a v10 backport once merged