-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(nestjs)!: Remove import-in-the-middle instrumentation #22805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andreiborza
wants to merge
7
commits into
develop
Choose a base branch
from
ab/js-3206-nestjs-channel-based
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0c1226d
ref(nestjs): Remove import-in-the-middle instrumentation
andreiborza 5c2d0b2
Trim redundant comment on nestIntegration
andreiborza a86f39d
Trim redundant comments in span-origin test
andreiborza 05f3582
Rename span-origin describe block
andreiborza c88c430
Drop changelog entry
andreiborza 49b1eea
Remove dead orchestrion marker from test
andreiborza cad53a7
Move orchestrion subscriber test to integrations dir
andreiborza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,16 @@ | ||
| import { NestInstrumentation as NestInstrumentationCore } from './vendored/instrumentation'; | ||
| import { defineIntegration } from '@sentry/core'; | ||
| import { generateInstrumentOnce } from '@sentry/node'; | ||
| import { isOrchestrionInjected } from '@sentry/server-utils/orchestrion'; | ||
| import { subscribeToNestChannels } from './orchestrion-subscriber'; | ||
| import { SentryNestBullMQInstrumentation } from './sentry-nest-bullmq-instrumentation'; | ||
| import { SentryNestEventInstrumentation } from './sentry-nest-event-instrumentation'; | ||
| import { SentryNestInstrumentation } from './sentry-nest-instrumentation'; | ||
| import { SentryNestScheduleInstrumentation } from './sentry-nest-schedule-instrumentation'; | ||
|
|
||
| const INTEGRATION_NAME = 'Nest' as const; | ||
|
|
||
| const instrumentNestCore = generateInstrumentOnce(`${INTEGRATION_NAME}.Core`, () => { | ||
| return new NestInstrumentationCore(); | ||
| }); | ||
|
|
||
| const instrumentNestCommon = generateInstrumentOnce(`${INTEGRATION_NAME}.Common`, () => { | ||
| return new SentryNestInstrumentation(); | ||
| }); | ||
|
|
||
| const instrumentNestEvent = generateInstrumentOnce(`${INTEGRATION_NAME}.Event`, () => { | ||
| return new SentryNestEventInstrumentation(); | ||
| }); | ||
|
|
||
| const instrumentNestSchedule = generateInstrumentOnce(`${INTEGRATION_NAME}.Schedule`, () => { | ||
| return new SentryNestScheduleInstrumentation(); | ||
| }); | ||
|
|
||
| const instrumentNestBullMQ = generateInstrumentOnce(`${INTEGRATION_NAME}.BullMQ`, () => { | ||
| return new SentryNestBullMQInstrumentation(); | ||
| }); | ||
|
|
||
| export const instrumentNest = Object.assign( | ||
| (): void => { | ||
| instrumentNestCore(); | ||
| instrumentNestCommon(); | ||
| instrumentNestEvent(); | ||
| instrumentNestSchedule(); | ||
| instrumentNestBullMQ(); | ||
| }, | ||
| { id: INTEGRATION_NAME }, | ||
| ); | ||
|
|
||
| /** | ||
| * Integration capturing tracing data for NestJS. | ||
| * Only the span origin differs between otel and orchestrion implementations. | ||
| * See the shared `./wrap-*` helpers | ||
| */ | ||
| export const nestIntegration = defineIntegration(() => { | ||
| return { | ||
| name: INTEGRATION_NAME, | ||
| setupOnce() { | ||
| if (isOrchestrionInjected()) { | ||
| subscribeToNestChannels(); | ||
| } else { | ||
| instrumentNest(); | ||
| } | ||
| subscribeToNestChannels(); | ||
| }, | ||
| }; | ||
| }); |
77 changes: 0 additions & 77 deletions
77
packages/nestjs/src/integrations/sentry-nest-bullmq-instrumentation.ts
This file was deleted.
Oops, something went wrong.
72 changes: 0 additions & 72 deletions
72
packages/nestjs/src/integrations/sentry-nest-event-instrumentation.ts
This file was deleted.
Oops, something went wrong.
115 changes: 0 additions & 115 deletions
115
packages/nestjs/src/integrations/sentry-nest-instrumentation.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left them as
.orchestrion.because Isaac's PR is removing these.