feat(sveltekit)!: Enable orchestrion instrumentation on Cloudflare - #22967
Merged
chargome merged 2 commits intoAug 4, 2026
Merged
Conversation
Wire up orchestrion build-time instrumentation for the SvelteKit Cloudflare adapter, which was previously skipped. On workerd the channel subscribers can't be registered via require-patching, so the plugin injects a build-time marker that @sentry/cloudflare reads at runtime. Ref: #22764 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 96effb7. Configure here.
chargome
marked this pull request as ready for review
August 3, 2026 16:23
chargome
requested review from
JPeer264,
andreiborza,
nicohrubec and
s1gr1d
and removed request for
a team and
s1gr1d
August 3, 2026 16:23
JPeer264
approved these changes
Aug 4, 2026
| sentryOrchestrionPlugin({ | ||
| buildTimeInstrumentation: mergedOptions.buildTimeInstrumentation, | ||
| // On Cloudflare, subscribers are wired via a build-time marker the SDK reads at runtime; | ||
| ...(mergedOptions.adapter === 'cloudflare' ? { injectChannelSubscribers: true } : {}), |
Member
There was a problem hiding this comment.
q: Shouldn't we consolidate injectChannelSubscribers and buildTimeInstrumentation into one?
(not important for this PR though)
Member
Author
There was a problem hiding this comment.
No, buildTimeInstrumentation is just the global opt-out and injectChannelSubscribers is changing how we register the subscribers. afaik we do not unify these two?
chargome
deleted the
charlygomez/js-3205-sveltekit-cloudflare-orchestrion
branch
August 4, 2026 07:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up orchestrion build-time instrumentation for the SvelteKit Cloudflare adapter, which was previously skipped. On workerd the channel subscribers can't be registered via require-patching, so the plugin injects a build-time marker that @sentry/cloudflare reads at runtime.
Ref: #22764