test(e2e): Add missing @sentry/core dep to nextjs-16-userfeedback - #22988
Merged
Conversation
`tests/feedback.test.ts` imports `FeedbackEvent` from `@sentry/core`, which the app never declared. It resolved only via the monorepo root symlink, so it broke once CI copied the app out of tree, and Next 16.3 surfaced it by no longer filtering diagnostics in test files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
marked this pull request as ready for review
August 4, 2026 09:40
chargome
enabled auto-merge (squash)
August 4, 2026 09:40
nicohrubec
approved these changes
Aug 4, 2026
JPeer264
approved these changes
Aug 4, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "test:assert": "pnpm test:prod" | ||
| }, | ||
| "dependencies": { | ||
| "@sentry/core": "file:../../packed/sentry-core-packed.tgz", |
Contributor
There was a problem hiding this comment.
Bug: The @sentry/core package is listed as a runtime dependency but is only used for a type-only import in a test file. It should be a devDependency.
Severity: LOW
Suggested Fix
In package.json, move the @sentry/core entry from the dependencies object to the devDependencies object. This correctly reflects that the package is only needed for development and type-checking, not for the runtime execution of the application.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/e2e-tests/test-applications/nextjs-16-userfeedback/package.json#L14
Potential issue: The `@sentry/core` package is incorrectly listed in `dependencies`. It
is only used for a type-only import (`import type { FeedbackEvent } ...`) within the
test file `tests/feedback.test.ts`. Since TypeScript strips type-only imports during
compilation, this package is not required for the application to run. This leads to
incorrect package configuration and potential bundle bloat. For consistency, it should
be moved to `devDependencies`, similar to how other test applications in this repository
handle type-only test dependencies.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares
@sentry/coreas a dependency of thenextjs-16-userfeedbackE2E app, fixing theE2E nextjs-16-userfeedback Testjob.