test(effect): Re-enable effect server transaction e2e tests - #23059
Merged
Conversation
The no-tracer-provider default in `@sentry/node` (`skipOpenTelemetrySetup: true`) restores the AsyncLocalStorage async-context strategy that Effect's fiber model relies on, so the Effect tracer spans become the `http.server` transaction again. Un-fixme the transaction e2e tests in effect-3-node and effect-4-node. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
batman begin |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8e22086. Configure here.
andreiborza
marked this pull request as ready for review
August 5, 2026 13:43
nicohrubec
approved these changes
Aug 5, 2026
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Un-
fixmethe transaction e2e tests ineffect-3-nodeandeffect-4-node. No SDK code change is needed.Why
The no-tracer-provider default landed for
@sentry/node(skipOpenTelemetrySetupdefaults totrue), which installs the AsyncLocalStorage async-context strategy instead of the OpenTelemetry one. That strategy matches Effect's fiber model, so theSentryEffectTracerspan propagates across the HTTP request boundary and becomes thehttp.servertransaction again, exactly as it did under the old@sentry/node-core/lightsetup. The tests were fixme'd during the node-core merge; the dependency work has since unblocked them.Closes: #22487