Skip to content

feat(solid,solidstart): Support @solidjs/router v1 #23162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 1 commit into from
Aug 7, 2026
+8 −8
Merged

feat(solid,solidstart): Support @solidjs/router v1 #23162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/solid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@sentry/conventions": "^0.16.0"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4 || ^0.14.0 || ^0.15.0",
"@solidjs/router": ">=0.13.4 <2.0.0-0",

@sentry sentry Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The widened peer dependency range for @solidjs/router is not tested against its minimum supported version, risking runtime crashes for users on older router versions.
Severity: HIGH

Suggested Fix

Add a testing step to the CI pipeline that installs and runs the test suite against the minimum supported version of the @solidjs/router dependency (0.13.4). This will validate that the hooks used by the SDK are compatible across the entire declared peer dependency range. Alternatively, narrow the peer dependency range to versions known to be compatible.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: packages/solid/package.json#L62

Potential issue: The peer dependency for `@solidjs/router` was broadened to `>=0.13.4
<2.0.0-0`, but the test suite only validates compatibility against version `1.0.0`. The
SDK integration uses the `useBeforeLeave`, `useCurrentMatches`, and `useLocation` hooks
without any error handling or version checks. If there were any breaking API changes in
`@solidjs/router` between version `0.13.4` and the latest tested version, users with
older, valid versions of the router would experience runtime crashes when the Sentry
integration initializes.

Also affects:

  • packages/solidstart/package.json:74~74

Did we get this right? 👍 / 👎 to inform future reviews.

"@tanstack/solid-router": "^1.132.27",
"solid-js": "^1.8.4"
},
Expand All @@ -72,7 +72,7 @@
}
},
"devDependencies": {
"@solidjs/router": "^0.15.0",
"@solidjs/router": "^1.0.0",
"@solidjs/testing-library": "0.8.5",
"@tanstack/solid-router": "^1.169.2",
"@testing-library/dom": "^7.21.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/solidstart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"access": "public"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4 || ^0.14.0 || ^0.15.0 || ^1.0.0",
"@solidjs/router": ">=0.13.4 <2.0.0-0",
"@solidjs/start": "^1.0.0 || ^2.0.0"
},
"peerDependenciesMeta": {
Expand All @@ -89,7 +89,7 @@
"@sentry/conventions": "0.16.0"
},
"devDependencies": {
"@solidjs/router": "^0.15.0",
"@solidjs/router": "^1.0.0",
"@solidjs/start": "^1.2.1",
"@solidjs/testing-library": "0.8.5",
"@testing-library/jest-dom": "^6.4.5",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8191,10 +8191,10 @@
resolved "https://registry.yarnpkg.com/@solidjs/meta/-/meta-0.29.4.tgz#28a444db5200d1c9e4e62d8762ea808d3e8beffd"
integrity sha512-zdIWBGpR9zGx1p1bzIPqF5Gs+Ks/BH8R6fWhmUa/dcK1L2rUC8BAcZJzNRYBQv74kScf1TSOs0EY//Vd/I0V8g==

"@solidjs/router@^0.15.0":
version "0.15.4"
resolved "https://registry.yarnpkg.com/@solidjs/router/-/router-0.15.4.tgz#e2b2d797541dcbdc36641e5f610f93ab4fa11c8a"
integrity sha512-WOpgg9a9T638cR+5FGbFi/IV4l2FpmBs1GpIMSPa0Ce9vyJN7Wts+X2PqMf9IYn0zUj2MlSJtm1gp7/HI/n5TQ==
"@solidjs/router@^1.0.0":
version "1.0.0"
resolved "https://registry.yarnpkg.com/@solidjs/router/-/router-1.0.0.tgz#9e4e5d6dbdeb725e8e4a9b5a3c7158c39fff096f"
integrity sha512-cCSk1hvgCowiMa9bzzYWHiLu1U4E22+DfJe6/rOwAyECKrxc3jrd5QnoW3sDDJtW+e077cz/M67bPl3DqOBw1Q==

"@solidjs/start@^1.2.1":
version "1.2.1"
Expand Down
Loading