feat(v10/solid,solidstart): Support @solidjs/router v1 - #23163
Merged
Conversation
andreiborza
marked this pull request as ready for review
August 7, 2026 16:56
andreiborza
requested review from
a team,
logaretm,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team and
mydea
August 7, 2026 16:56
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 54e5079. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| }, | ||
| "peerDependencies": { | ||
| "@solidjs/router": "^0.13.4 || ^0.14.0 || ^0.15.0", | ||
| "@solidjs/router": ">=0.13.4 <2.0.0-0", |
Contributor
There was a problem hiding this comment.
Bug: The peer dependency for @solidjs/router was updated to include v1.x, but the code using useBeforeLeave is not compatible with the breaking API changes, likely causing runtime errors.
Severity: HIGH
Suggested Fix
Update the implementation in packages/solid/src/solidrouter.ts to be compatible with the breaking changes in @solidjs/router v1.0.0, specifically how the useBeforeLeave event argument is handled. Alternatively, revert the peer dependency range in package.json to exclude v1.x versions.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/solid/package.json#L62
Potential issue: The peer dependency for `@solidjs/router` was updated to allow v1.x,
but the implementation in `packages/solid/src/solidrouter.ts` was not updated to handle
breaking changes. The code uses `useBeforeLeave` and expects the `to` property from the
event argument to be a string-like value. However, v1.0.0 of the router changes `to` to
be a location object. Calling `to.toString()` on this object will likely result in a
runtime error or incorrect behavior during navigation, as the code is not prepared to
handle the new object structure.
Also affects:
packages/solidstart/package.json:60~60
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
size-limit report 📦
|
logaretm
approved these changes
Aug 7, 2026
andreiborza
added a commit
that referenced
this pull request
Aug 7, 2026
) ## What Bump `@solidjs/router` from `^0.15.0` to `^1.0.0` in the SolidStart 1 e2e test apps. - `solidstart`, `solidstart-spa`, `solidstart-top-level-import`, `solidstart-dynamic-import` ## Why #23162 widened the `@solidjs/router` peer range to `>=0.13.4 <2.0.0-0`, but only the `solidstart-2` app ran against v1, so the SolidStart 1 + router v1 combination the range now advertises had no coverage. The equivalent bump on v10 (#23163) passes all four suites locally. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #23162