feat(core): Remove span from ScopeData - #23225
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
August 10, 2026 13:08
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+91
to
+94
| const span = getActiveSpan(finalScope); | ||
| if (span) { | ||
| applySpanToEvent(prepared, span); | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: When captureContext is used, scope.clone() is called but fails to copy the OpenTelemetry context (_scopeContext), causing the active span to be lost from the event.
Severity: HIGH
Suggested Fix
The Scope.clone() method should be updated to also copy the _scopeContext from the original scope to the new one. Alternatively, getActiveSpan could be modified to fall back to the global trace.getActiveSpan() if getContextFromScope(scope) returns undefined, which would align its behavior with the case where no scope is provided.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/core/src/utils/prepareEvent.ts#L91-L94
Potential issue: When an event is captured with a `captureContext`, the associated scope
is cloned via `scope.clone()`. This cloning process does not copy the `_scopeContext`
property, which is used by the OpenTelemetry integration to link to the active OTEL
context. The new logic in `prepareEvent.ts` attempts to get the active span from this
cloned scope. Because the `_scopeContext` is missing, `getActiveSpan` returns
`undefined` and does not fall back to the global active span. This results in the active
span being dropped from the event, breaking tracing for any errors captured with a
`captureContext`.
Did we get this right? 👍 / 👎 to inform future reviews.
logaretm
approved these changes
Aug 10, 2026
We can look this up directly/manually instead.
mydea
force-pushed
the
fn/remove-span-scope-data
branch
from
August 11, 2026 07:12
ba2311e to
5176783
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5176783. Configure here.
|
|
||
| expect(processedEvent?.transaction).toBe('/users/:id'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Missing integration or E2E tests
Low Severity
This is a feat PR but only adds unit tests for active-span application in prepareEvent. Per the testing conventions in the review rules, a feat PR should include at least one integration or E2E test covering the new behavior end-to-end.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 5176783. Configure here.
mydea
added a commit
that referenced
this pull request
Aug 11, 2026
We no longer need this after #23225, as this should now pick up the correct span also for otel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can look this up directly/manually instead - this unlinks these (partially), some follow up work is still needed but this is a part of it.