ref(core): Streamline how active spans are set in core - #23254
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f4c52a. Configure here.
andreiborza
approved these changes
Aug 11, 2026
Contributor
size-limit report 📦
|
mydea
commented
Aug 11, 2026
| ? (callback: () => T) => { | ||
| return withActiveSpan(span, () => { | ||
| // Make sure the correct scope is captured on the span | ||
| setCapturedScopesOnSpan(span, getCurrentScope(), getIsolationScope()); |
Member
Author
There was a problem hiding this comment.
@andreiborza had to add this too to make tests pass, maybe this was part of the problem you ran into before with tags/scopes not matching properly 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted out of #23198, I think this should work...