feat(server-utils): Emit low cardinality mongoose db span names - #23782
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-core-mongoose-low-card-span-names
branch
from
August 31, 2026 16:55
9290d85 to
797e077
Compare
Lms24
marked this pull request as ready for review
August 31, 2026 16:55
Lms24
changed the title
chargome
approved these changes
Sep 2, 2026
chargome
left a comment
chargome
left a comment
Member
There was a problem hiding this comment.
Migration still needs an update for this, we should also point out that this also changes db.system.name for static.
Also logaf-L: PR title should be feat(server-utils)!:
Lms24
changed the title
Lms24
changed the title
Mongoose spans wrap an ODM-level operation. With span streaming enabled:
- mongoose spans become `{db.operation.name} {db.collection.name}`, e.g.
`findOne blogposts`
- falls back to `db.namespace`, then to `db.system.name`
- `traceLifecycle: 'static'` keeps the existing `mongoose.<Model>.<op>` names
Also corrects `db.system.name` on the monkey-patch path from `mongoose` to
`mongodb`, matching the diagnostics-channel path.
Refs #23523
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Add the mongoose row to the v11 span name table and note that the `db.system.name` change from `mongoose` to `mongodb` applies in both trace lifecycles, not just with span streaming. Refs #23523 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-core-mongoose-low-card-span-names
branch
from
September 2, 2026 08:28
81f6ac7 to
31f82da
Compare
Lms24
enabled auto-merge (squash)
September 2, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
{db.operation.name} {db.collection.name}, e.g.findOne blogpostsdb.namespace, then todb.system.nameBlogPost) is no longer part of the name — the conventions template usesdb.collection.name(blogposts), which is what both mongoose paths already settraceLifecycle: 'static'keeps the existingmongoose.<Model>.<op>namesAlso corrects
db.system.nameon the monkey-patch path frommongoosetomongodb.mongooseis not a database system, and the diagnostics-channel path already emittedmongodb.Added streaming node-integration tests for all mongoose test suites.
Refs #23523