fix(core): do not unnecessarily defer offline transport send - #24027
Open
isaacs wants to merge 1 commit into
Open
fix(core): do not unnecessarily defer offline transport send#24027isaacs wants to merge 1 commit into
isaacs wants to merge 1 commit into
Conversation
`makeOfflineTransport` awaited the `shouldSend` result unconditionally. The option type allows a plain boolean, and awaiting one still costs a microtask tick, so a synchronous callback pushed the call to `transport.send()` into the next turn. Only await when the callback returns a thenable. Hosts such as Douyin mini-games stop JS execution when the app goes to the background, so that one tick was enough to lose the event: the envelope had not reached the transport, and the offline store only gets written in the `catch` branch, which never runs when `shouldSend` returns true. Behavior is unchanged for callbacks that return a promise. fixes #24005 fixes JS-3560 Co-Authored-By: yaoxp <viq_xp@126.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeOfflineTransportawaited theshouldSendresult unconditionally. The option type allows a plain boolean, and awaiting one still costs a microtask tick, so a synchronous callback pushed the call totransport.send()into the next turn.Only await when the callback returns a thenable. Hosts such as Douyin mini-games stop JS execution when the app goes to the background, so that one tick was enough to lose the event: the envelope had not reached the transport, and the offline store only gets written in the
catchbranch, which never runs whenshouldSendreturns true.Behavior is unchanged for callbacks that return a promise.
fixes #24005
fixes JS-3560