test(e2e): Restore scope isolation coverage on spans under span streaming - #24055
Merged
Conversation
…ming The span streaming port dropped the isolation-scope assertions on the Next.js 16 middleware specs because streamed spans carry no scope tags. The test apps now report the isolation state as span attributes, and the nextjs-16 route handler behind the proxy does the same so the leak guard for vercel/next.js#95306 is back. Fixes #23941 Refs JS-3534 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4c8e80a. Configure here.
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
September 4, 2026 07:21
andreiborza
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the isolation-scope assertions the span streaming port dropped from the Next.js 16 middleware specs by having the test apps report isolation state as span attributes instead of scope tags.
Fixes #23941