fix(astro): Fall back to dataCollection.userInfo for trackClientIp - #24091
Open
s1gr1d wants to merge 2 commits into
Open
fix(astro): Fall back to dataCollection.userInfo for trackClientIp#24091s1gr1d wants to merge 2 commits into
dataCollection.userInfo for trackClientIp#24091s1gr1d wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
s1gr1d
marked this pull request as ready for review
September 4, 2026 12:46
s1gr1d
requested review from
chargome and
mydea
and removed request for
a team
September 4, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleRequesthard-defaultedtrackClientIptofalse, so the globaldataCollection.userInfocould never switch client IP collection on. An integration option is only meant to win when the user actually sets it.It is now
options.trackClientIp ?? dataCollection.userInfo. Heads up, this changes the default. Astro apps that leave both alone start reportinguser.ip_address, matchinguserInfo's documented default oftrueand what the other server SDKs do.Fixes #24086