test(e2e): Restore dropped url attribute assertions in the astro-4 and astro-5 specs - #24113
Open
andreiborza wants to merge 1 commit into
Open
test(e2e): Restore dropped url attribute assertions in the astro-4 and astro-5 specs#24113andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
…d astro-5 specs The span-streaming port dropped `url.template`, `url.path` and `url.full` from the client pageload assertions in the static and server-island specs.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Puts
url.template,url.pathandurl.fullback on the client pageload assertions inastro-4/tests/tracing.static,astro-5/tests/tracing.staticandastro-5/tests/tracing.serverIslands, as streamed span attributes.Why
The span-streaming ports (#24079, #24078) dropped them by accident. Lukas spotted the same drop in astro-6 on #24077, where it is fixed in place; these two apps had already merged.
Ref: #23809