fix(native): let WER finish native crash reports#1904
Merged
Conversation
The native WER runtime exception callback previously terminated the crashed process after signaling the native daemon. That made sense for the original WER capture path: once the callback claimed ownership and the daemon had been notified, terminating the process ensured the crash was finalized even when the crashed thread did not return normally. However, terminating from the callback prevents WER from completing its normal report generation. In particular, Report.wer can be written without custom metadata registered by the crashed process, so Sentry's WER integration tags are missing from native fast-fail reports. Keep claiming ownership and keep waiting for daemon processing, but return control to WER afterwards. This lets WER complete the report, including registered custom metadata, while the native daemon still captures and uploads the Sentry crash event. Add WER compatibility coverage documenting which backends allow WER to see SEH and fast-fail crashes alongside Sentry capture.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1904 +/- ##
=======================================
Coverage 75.76% 75.77%
=======================================
Files 92 92
Lines 21989 21989
Branches 3918 3918
=======================================
+ Hits 16661 16663 +2
+ Misses 4447 4444 -3
- Partials 881 882 +1 🚀 New features to boost your workflow:
|
6 tasks
mujacica
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native WER runtime exception callback previously terminated the crashed process after signaling the native daemon. That made sense for the original WER capture path: once the callback claimed ownership and the daemon had been notified, terminating the process ensured the crash was finalized even when the crashed thread did not return normally.
However, terminating from the callback prevents WER from completing its normal report generation. In particular,
Report.wercan be written without custom metadata registered by the crashed process, so Sentry's WER integration tags are missing from native fast-fail reports.Keep claiming ownership and keep waiting for daemon processing, but return control to WER afterwards. This lets WER complete the report, including registered custom metadata, while the native daemon still captures and uploads the Sentry crash event.
Add
test_wer_compatibilitydocumenting which backends allow WER to see SEH and fast-fail crashes alongside Sentry capture: