fix: close fd 0 when mmap fails - #1924
Merged
jpnurmi merged 6 commits intoAug 4, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0bcad10. Configure here.
```
tests/unit/test_modulefinder.c: In function ‘test_sentry_mmap_file_closes_fd_zero_on_failure’:
tests/unit/test_modulefinder.c:95:19: error: implicit declaration of function ‘sentry__mmap_file’; did you mean ‘sentry_attach_file’? [-Wimplicit-function-declaration]
95 | bool mapped = sentry__mmap_file(&mmap, tmp_path);
| ^~~~~~~~~~~~~~~~~
```
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
+ Coverage 75.87% 75.93% +0.06%
==========================================
Files 93 93
Lines 22183 22183
Branches 3951 3951
==========================================
+ Hits 16831 16845 +14
+ Misses 4467 4453 -14
Partials 885 885 🚀 New features to boost your workflow:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stdin is closed,
open()can return file descriptor 0. The failure cleanup insentry__mmap_fileonly closed descriptors greater than 0, which leaked the file descriptor if a later step failed.Close every non-negative descriptor and add a Linux regression test that exercises the empty-file failure path with stdin closed.