feat(billing): Add has_card_on_file to StripePaymentData#301
Merged
skonves merged 2 commits intoJun 10, 2026
Merged
Conversation
Add an optional `has_card_on_file` boolean to the StripePaymentData message. This lets consumers in the billing platform answer "does this org have a card on file?" without a separate RPC — it is populated inside `BillingDetailsService.get_stripe_payment_data` from the local `PaymentMethod` mirror table, matching the legacy `Subscription.has_card_on_file()` check. The immediate consumer is platform invoice PDF generation, which today hardcodes the auto-renewal disclaimer regardless of whether the org has a card on file (incorrectly shown for invoiced customers). The getsentry implementation lands in a separate PR. Refs REVENG-155 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
volokluev
approved these changes
Jun 10, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
optional bool has_card_on_file = 3field toStripePaymentData, letting consumers determine whether an org has a card on file without a separate RPC. The field is populated insideBillingDetailsService.get_stripe_payment_datafrom the localPaymentMethodmirror table, mirroring the legacySubscription.has_card_on_file()check.The immediate consumer is platform invoice PDF generation, which today hardcodes the auto-renewal disclaimer regardless of whether the org has a card on file (incorrectly shown for invoiced customers). The
getsentryimplementation lands in a separate follow-up PR.Refs REVENG-155