ref(billing-platform): Use TieredPricingRate in SharedLineItemPool#302
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
krithikravi
reviewed
Jun 10, 2026
krithikravi
reviewed
Jun 10, 2026
krithikravi
approved these changes
Jun 10, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in an effort to address some comments from https://github.com/getsentry/getsentry/pull/20604#discussion_r3391705426
This will remove the need to store
reserved_price_centsin UserParameters for shared line item pools. Prices can be part of PackageConfigs and at invoicing time we just look up the tier's correct price. Also, gives us the added benefit of specifying more than 1reserved_pool_cents(if that ever becomes necessary)