feat(snuba): Add conversation_id and session_id to TraceItem#324
Merged
Conversation
Add conversation_id and session_id string fields to the TraceItem protobuf so trace items can be associated with a conversation and session. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016oMzThA3hxjuciMrJU8AgF
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
MeredithAnya
approved these changes
Jun 23, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new string fields to the
TraceItemprotobuf (proto/sentry_protos/snuba/v1/trace_item.proto):conversation_id(field10) — the ID of the conversation this item belongs to, if any.session_id(field11) — the ID of the session this item belongs to, if any.These let trace items be associated with a conversation and a session.
Details
string, consistent with the existingtrace_idfield.10,11) in the public field range, so the change is purely additive and backwards compatible.rust/src/sentry_protos.snuba.v1.rs). The Python bindings are gitignored, so they are not committed (they regenerate from the proto).Cargo.lockpicked up an in-flight0.32.4 → 0.32.5version sync, matching the pattern of other recent feature PRs.CHANGELOG.md/VERSIONare intentionally left untouched — those are bumped by the automated release process, not in feature PRs.Testing
make build-rust(regenerates bindings; compiles cleanly viacargo build).make build-py(Python bindings generate successfully).pytest py/tests/test_snuba_v1.py— all 14 tests pass.🤖 Generated with Claude Code
Generated by Claude Code