chore(billing-platform): Add start_new_term to from checkout service to rollover - #392
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
brendanhsentry
marked this pull request as ready for review
August 3, 2026 19:38
skonves
reviewed
Aug 3, 2026
| bool immediate = 8; | ||
|
|
||
| // Whether the requested change should result in a new billing period. | ||
| bool start_new_term = 9; |
Member
There was a problem hiding this comment.
We might want to combine this with immediate in some form of enum. As it stands, both immediate and start_new_term being set to true seems to be self-contradictory.
skonves
approved these changes
Aug 3, 2026
skonves
left a comment
skonves
left a comment
Member
There was a problem hiding this comment.
We should update the comment on immediate to just
// Roll the contract over as of now instead of at its period end: the current
// contract is closed immediately and the new contract starts now.
I think the rest is now either wrong or misleading.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkout service determines whether we should apply immediate changes to the current term or if we should start a new billing period.