Skip to content

test(basics): Stop using configure_scope #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 26, 2024
Merged

test(basics): Stop using configure_scope #3349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions tests/test_basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from sentry_sdk import (
get_client,
push_scope,
configure_scope,
capture_event,
capture_exception,
capture_message,
Expand Down Expand Up @@ -74,13 +73,11 @@ def test_processors(sentry_init, capture_events):
sentry_init()
events = capture_events()

with configure_scope() as scope:

def error_processor(event, exc_info):
event["exception"]["values"][0]["value"] += " whatever"
return event
def error_processor(event, exc_info):
event["exception"]["values"][0]["value"] += " whatever"
return event

scope.add_error_processor(error_processor, ValueError)
Scope.get_isolation_scope().add_error_processor(error_processor, ValueError)

try:
raise ValueError("aha!")
Expand Down Expand Up @@ -432,9 +429,9 @@ def test_attachments(sentry_init, capture_envelopes):

this_file = os.path.abspath(__file__.rstrip("c"))

with configure_scope() as scope:
scope.add_attachment(bytes=b"Hello World!", filename="message.txt")
scope.add_attachment(path=this_file)
scope = Scope.get_isolation_scope()
scope.add_attachment(bytes=b"Hello World!", filename="message.txt")
scope.add_attachment(path=this_file)

capture_exception(ValueError())

Expand Down Expand Up @@ -466,8 +463,7 @@ def test_attachments_graceful_failure(
sentry_init()
envelopes = capture_envelopes()

with configure_scope() as scope:
scope.add_attachment(path="non_existent")
Scope.get_isolation_scope().add_attachment(path="non_existent")
capture_exception(ValueError())

(envelope,) = envelopes
Expand Down