Skip to content

test: Remove flaky circular references tests - #6903

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/remove-circular-reference-tests
Jul 28, 2026
Merged

test: Remove flaky circular references tests#6903
alexander-alderman-webb merged 1 commit into
masterfrom
webb/remove-circular-reference-tests

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Tests should not rely on garbage collection details, as it isn't our job to test the garbage collector.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 28, 2026 11:36
@alexander-alderman-webb alexander-alderman-webb changed the title test: Remove flaky circular references test test: Remove flaky circular references tests Jul 28, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98711 passed | ⏭️ 6806 skipped | Total: 105517 | Pass Rate: 93.55% | Execution Time: 348m 54s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -19
Passed Tests 📉 -16
Failed Tests 📉 -3
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_circular_references_span_streaming
    • File: tests.tracing.test_misc

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2562 uncovered lines.
✅ Project coverage is 89.55%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.55%    89.55%        —%
==========================================
  Files          193       193         —
  Lines        24520     24520         —
  Branches      8676      8676         —
==========================================
+ Hits         21958     21958         —
- Misses        2562      2562         —
- Partials      1402      1402         —

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit bea60a4 into master Jul 28, 2026
271 of 273 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/remove-circular-reference-tests branch July 28, 2026 11:57
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
The tests were failing on 3.14t as they rely on garbage collection details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants