ref: Remove old OTel support code - #6935
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d277130. Configure here.
|
|
||
|
|
||
| SENTRY_BAGGAGE_KEY = create_key("sentry-baggage") | ||
| SENTRY_TRACE_KEY = create_key("sentry-trace") |
There was a problem hiding this comment.
Unused SENTRY_TRACE_KEY after move
Low Severity
SENTRY_TRACE_KEY is defined and written in extract, but nothing in the codebase reads it anymore. The old SentrySpanProcessor was the only consumer of that context value (parent_sampled), so after removing that processor this is a dead store left over from the move.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d277130. Configure here.
| # OpenTelemetry with OTLP | ||
| otlp: opentelemetry-distro[otlp] | ||
| otlp: responses | ||
| otlp: pytest-forked |
There was a problem hiding this comment.
Orphaned pytest-forked in tox
Low Severity
pytest-forked was moved onto the otlp tox env in tox.ini, but otlp tests do not use @pytest.mark.forked, and the same dependency was not added to tox.jinja. That leaves an unused CI dependency and drifts the generated file from its template source.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d277130. Configure here.
Codecov Results 📊✅ 96436 passed | ⏭️ 6371 skipped | Total: 102807 | Pass Rate: 93.8% | Execution Time: 350m 15s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 87.88%. Project has 2451 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.86% 89.59% -0.27%
==========================================
Files 193 186 -7
Lines 24645 23553 -1092
Branches 8780 8366 -414
==========================================
+ Hits 22147 21102 -1045
- Misses 2498 2451 -47
- Partials 1400 1346 -54Generated by Codecov Action |


integrations/opentelemetry(SentrySpanProcessor,SentryPropagator, etc.)OTLPIntegrationto the OTLP propagator directlyinstrumenterNote:
NoOpSpanwas not removed because it makes mypy blow up. Not worth the effort as we'll anyway get rid of it when dropping transaction based tracing.Issues
Closes #6932
Reminders
uv run ruff.feat:,fix:,ref:,meta:)