Skip to content

ref: Drop support for legacy failed_request_status_codes format in new major - #6948

Merged
sentrivana merged 4 commits into
major/3.0from
ivana/clean-up-request-status-code
Jul 30, 2026
Merged

ref: Drop support for legacy failed_request_status_codes format in new major#6948
sentrivana merged 4 commits into
major/3.0from
ivana/clean-up-request-status-code

Conversation

@sentrivana

@sentrivana sentrivana commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

When failed_request_status_codes was first introduced, it accepted a different format. The format was then changed, while the old format was deprecated. Drop support for the old format now.

Issues

Closes #5017

Reminders

@sentrivana sentrivana changed the title ref: Drop support for old failed_request_status_codes format ref: Drop support for legacy failed_request_status_codes format Jul 30, 2026
@sentrivana sentrivana changed the title ref: Drop support for legacy failed_request_status_codes format ref: Drop support for legacy failed_request_status_codes format in new major Jul 30, 2026
@sentrivana
sentrivana marked this pull request as ready for review July 30, 2026 08:52
@sentrivana
sentrivana requested a review from a team as a code owner July 30, 2026 08:52
@sentrivana
sentrivana merged commit 2a338a0 into major/3.0 Jul 30, 2026
135 of 138 checks passed
@sentrivana
sentrivana deleted the ivana/clean-up-request-status-code branch July 30, 2026 09:01
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

96291 passed | ❌ 2 failed | ⏭️ 6337 skipped | Total: 102630 | Pass Rate: 93.82% | Execution Time: 362m 54s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -3026
Passed Tests 📉 -2587
Failed Tests 📈 +1
Skipped Tests 📉 -440

➕ New Tests (2)

View new tests
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[non-experiment-thread]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-thread]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[non-experiment-thread]

File: tests.profiler.test_continuous_profiler
Suite: py3.14t-common
Error: AssertionError: profiler should not be running assert '7df33b3ce9454a4396839a1657385e44' is None + where '7df33b3ce9454a4396839a1657385e44' = get_profiler_id()

Stack Trace
tests/profiler/test_continuous_profiler.py:896: in test_continuous_profiler_auto_start_and_stop_sampled_span_streaming
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert '7df33b3ce9454a4396839a1657385e44' is None
E    +  where '7df33b3ce9454a4396839a1657385e44' = get_profiler_id()

test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-thread]

File: tests.profiler.test_continuous_profiler
Suite: py3.7-common
Error: AssertionError: profiler should not be running assert '9bdf33d22cac44c28a0358e1ec1e0739' is None + where '9bdf33d22cac44c28a0358e1ec1e0739' = get_profiler_id()

Stack Trace
tests/profiler/test_continuous_profiler.py:896: in test_continuous_profiler_auto_start_and_stop_sampled_span_streaming
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert '9bdf33d22cac44c28a0358e1ec1e0739' is None
E    +  where '9bdf33d22cac44c28a0358e1ec1e0739' = get_profiler_id()

✅ Patch coverage is 100.00%. Project has 2392 uncovered lines.
✅ Project coverage is 89.87%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.87%    89.87%        —%
==========================================
  Files          193       186        -7
  Lines        24656     23615     -1041
  Branches      8786      8450      -336
==========================================
+ Hits         22158     21223      -935
- Misses        2498      2392      -106
- Partials      1400      1347       -53

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants