ref: Drop Starlette < 0.20, fastapi < 0.85 - #7044
Conversation
Codecov Results 📊✅ 92346 passed | ⏭️ 5429 skipped | Total: 97775 | Pass Rate: 94.45% | Execution Time: 334m 18s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2325 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.90% 90.18% +0.28%
==========================================
Files 193 186 -7
Lines 24822 23668 -1154
Branches 8924 8536 -388
==========================================
+ Hits 22315 21343 -972
- Misses 2507 2325 -182
- Partials 1417 1360 -57Generated by Codecov Action |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4aa551b. Configure here.
| ], | ||
| # See the comment on FastAPI's httpx bound for more info | ||
| "<0.37.2": ["httpx<0.28.0"], | ||
| "<0.15": ["jinja2<3.1"], |
There was a problem hiding this comment.
Missing Starlette urllib3 pin
Medium Severity
The new FastAPI deps comment says Starlette below 0.21 needs urllib3<2 because _MockOriginalResponse lacks close(), and FastAPI now pins that. The Starlette suite still tests 0.20.4 and installs requests without the same pin, so those envs can still resolve urllib3 2.x and hit the TestClient failure this change is meant to avoid.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 4aa551b. Configure here.


No description provided.