Skip to content

ref: Drop Starlette < 0.20, fastapi < 0.85 - #7044

Merged
sentrivana merged 4 commits into
major/3.0from
ivana/major/drop-starlette
Aug 5, 2026
Merged

ref: Drop Starlette < 0.20, fastapi < 0.85#7044
sentrivana merged 4 commits into
major/3.0from
ivana/major/drop-starlette

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

92346 passed | ⏭️ 5429 skipped | Total: 97775 | Pass Rate: 94.45% | Execution Time: 334m 18s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -5128
Passed Tests 📉 -4366
Failed Tests
Skipped Tests 📉 -762

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2325 uncovered lines.
✅ Project coverage is 90.18%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.90%    90.18%    +0.28%
==========================================
  Files          193       186        -7
  Lines        24822     23668     -1154
  Branches      8924      8536      -388
==========================================
+ Hits         22315     21343      -972
- Misses        2507      2325      -182
- Partials      1417      1360       -57

Generated by Codecov Action

@sentrivana sentrivana changed the title ref(starlette): Drop Starlette < 0.20 ref: Drop Starlette < 0.20, fastapi < 0.85 Aug 5, 2026
@sentrivana
sentrivana marked this pull request as ready for review August 5, 2026 13:53
@sentrivana
sentrivana requested a review from a team as a code owner August 5, 2026 13:53

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4aa551b. Configure here.

],
# See the comment on FastAPI's httpx bound for more info
"<0.37.2": ["httpx<0.28.0"],
"<0.15": ["jinja2<3.1"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Starlette urllib3 pin

Medium Severity

The new FastAPI deps comment says Starlette below 0.21 needs urllib3&lt;2 because _MockOriginalResponse lacks close(), and FastAPI now pins that. The Starlette suite still tests 0.20.4 and installs requests without the same pin, so those envs can still resolve urllib3 2.x and hit the TestClient failure this change is meant to avoid.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4aa551b. Configure here.

@sentrivana
sentrivana merged commit 5b95258 into major/3.0 Aug 5, 2026
130 checks passed
@sentrivana
sentrivana deleted the ivana/major/drop-starlette branch August 5, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants