Skip to content

chore(aiohttp): Remove transaction-based tracing - #7365

Merged
sentrivana merged 4 commits into
major/3.0from
ivana/major/remove-transactions-aiohttp
Sep 3, 2026
Merged

chore(aiohttp): Remove transaction-based tracing#7365
sentrivana merged 4 commits into
major/3.0from
ivana/major/remove-transactions-aiohttp

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

@linear-code

linear-code Bot commented Sep 3, 2026

Copy link
Copy Markdown

PY-2675

@sentrivana
sentrivana marked this pull request as ready for review September 3, 2026 12:11
@sentrivana
sentrivana requested a review from a team as a code owner September 3, 2026 12:11
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

100186 passed | ❌ 3 failed | ⏭️ 4494 skipped | Total: 104683 | Pass Rate: 95.7% | Execution Time: 348m 19s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -33012
Passed Tests 📉 -30399
Failed Tests 📈 +3
Skipped Tests 📉 -2616

➕ New Tests (2)

View new tests
  • test_chat_completion_data_collection[gen-ai-outputs-enabled-inputs-disabled]
    • File: tests.integrations.litellm.test_litellm
    • Status: ❌ Failing
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_chat_completion_data_collection[gen-ai-outputs-enabled-inputs-disabled]

File: tests.integrations.litellm.test_litellm
Suite: py3.10-litellm-v1.83.14
Error: ValueError: too many values to unpack (expected 1)

Stack Trace
tests/integrations/litellm/test_litellm.py:3394: in test_chat_completion_data_collection
    (event,) = events
E   ValueError: too many values to unpack (expected 1)

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.13-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:526: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:526: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 92.00%. Project has 2265 uncovered lines.
✅ Project coverage is 90.42%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/aiohttp.py 92.00% ⚠️ 6 Missing and 4 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.24%    90.42%    +0.18%
==========================================
  Files          193       185        -8
  Lines        25715     23644     -2071
  Branches      9502      8688      -814
==========================================
+ Hits         23206     21379     -1827
- Misses        2509      2265      -244
- Partials      1433      1365       -68

Generated by Codecov Action

@sentrivana
sentrivana merged commit f543c6b into major/3.0 Sep 3, 2026
146 of 149 checks passed
@sentrivana
sentrivana deleted the ivana/major/remove-transactions-aiohttp branch September 3, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants