Skip to content

chore(langchain): Remove transaction-based tracing - #7381

Draft
alexander-alderman-webb wants to merge 2 commits into
major/3.0from
webb/langchain/remove-transactions-2
Draft

chore(langchain): Remove transaction-based tracing#7381
alexander-alderman-webb wants to merge 2 commits into
major/3.0from
webb/langchain/remove-transactions-2

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Remove branches for the static trace lifecycle.
Also remove manual tracing API calls in tests, as the outer transaction is no longer needed.

Issues

Reminders

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

82732 passed | ❌ 13 failed | ⏭️ 3878 skipped | Total: 86623 | Pass Rate: 95.51% | Execution Time: 247m 43s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -51083
Passed Tests 📉 -47864
Failed Tests 📈 +13
Skipped Tests 📉 -3232

➕ New Tests (13)

View new tests
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_spans_from_multiple_threads[propagate_scope=True]
    • File: tests.integrations.threading.test_threading
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing
  • test_langchain_embeddings_error_handling
    • File: tests.integrations.langchain.test_langchain
    • Status: ❌ Failing

❌ Failed Tests

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.10-langchain-base-v1.3.18
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.10-langchain-base-v1.4.0a4
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.11-langchain-base-v0.1.20
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.12-langchain-base-v0.1.20
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.12-langchain-base-v0.3.30
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.13-langchain-base-v0.3.30
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.13-langchain-base-v1.3.18
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.13-langchain-base-v1.4.0a4
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.14-langchain-base-v1.3.18
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.14-langchain-base-v1.4.0a4
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_spans_from_multiple_threads[propagate_scope=True]

File: tests.integrations.threading.test_threading
Suite: py3.8-common
Error: AssertionError: assert '98924d7a647e7026' == 'b6ac19707bad4b9d' - b6ac19707bad4b9d + 98924d7a647e7026

Stack Trace
tests/integrations/threading/test_threading.py:180: in test_spans_from_multiple_threads
    assert span["parent_span_id"] == outer_submit_spans[num].span_id
E   AssertionError: assert '98924d7a647e7026' == 'b6ac19707bad4b9d'
E     
E     - b6ac19707bad4b9d
E     + 98924d7a647e7026

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.9-langchain-base-v0.1.20
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

test_langchain_embeddings_error_handling

File: tests.integrations.langchain.test_langchain
Suite: py3.9-langchain-base-v0.3.30
Error: assert 0 >= 1 + where 0 = len([])

Stack Trace
tests/integrations/langchain/test_langchain.py:2836: in test_langchain_embeddings_error_handling
    assert len(events) >= 1
E   assert 0 >= 1
E    +  where 0 = len([])

✅ Patch coverage is 100.00%. Project has 2367 uncovered lines.
❌ Project coverage is 89.88%. Comparing base (c3c44b1) to head (e2d31aa).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/langchain.py 100.00% ⚠️ 2 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.24%    89.88%    -0.36%
==========================================
  Files          193       185        -8
  Lines        25724     23386     -2338
  Branches      9504      8562      -942
==========================================
+ Hits         23214     21019     -2195
- Misses        2510      2367      -143
- Partials      1435      1366       -69

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant